jt2594838 commented on code in PR #16968:
URL: https://github.com/apache/iotdb/pull/16968#discussion_r2681246530
##########
iotdb-client/client-cpp/src/main/SessionConnection.h:
##########
@@ -179,6 +180,8 @@ class SessionConnection : public
std::enable_shared_from_this<SessionConnection>
TSStatus deleteDataInternal(TSDeleteDataReq request);
+ std::shared_ptr<apache::thrift::transport::TSSLSocketFactory>
socketFactory_ =
+ std::make_shared<apache::thrift::transport::TSSLSocketFactory>();;
Review Comment:
Is this thread-safe? If so, may define as static.
##########
iotdb-client/client-cpp/src/main/SessionConnection.h:
##########
@@ -179,6 +180,8 @@ class SessionConnection : public
std::enable_shared_from_this<SessionConnection>
TSStatus deleteDataInternal(TSDeleteDataReq request);
+ std::shared_ptr<apache::thrift::transport::TSSLSocketFactory>
socketFactory_ =
+ std::make_shared<apache::thrift::transport::TSSLSocketFactory>();;
Review Comment:
One extra `;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
