JackieTien97 commented on code in PR #17009:
URL: https://github.com/apache/iotdb/pull/17009#discussion_r2692708885
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNode.java:
##########
@@ -754,6 +761,7 @@ private void sendRestartRequestToConfigNode() throws
StartupException {
private void prepareResources() throws StartupException {
prepareUDFResources();
prepareTriggerResources();
+ prepareExternalServiceResources();
Review Comment:
better call this in `initProtocols` method
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNode.java:
##########
@@ -489,6 +492,10 @@ protected void storeRuntimeConfigurations(
/* Store triggerInformationList */
getTriggerInformationList(runtimeConfiguration.getAllTriggerInformation());
+ /* Store externalServiceEntryList */
+ resourcesInformationHolder.setExternalServiceEntryList(
+ runtimeConfiguration.getAllUserDefinedServiceInfo());
Review Comment:
runtimeConfiguration.isSetAllUserDefinedServiceInfo() ?
runtimeConfiguration.getAllUserDefinedServiceInfo() : Collections.empty_list();
##########
iotdb-protocol/thrift-confignode/src/main/thrift/confignode.thrift:
##########
@@ -121,6 +121,7 @@ struct TRuntimeConfiguration {
8: required TAuditConfig auditConfig
9: required string superUserName
10: optional bool enableSeparationOfAdminPowers
+ 11: required list<common.TExternalServiceEntry> allUserDefinedServiceInfo
Review Comment:
```suggestion
11: optional list<common.TExternalServiceEntry> allUserDefinedServiceInfo
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
