jt2594838 commented on code in PR #17055:
URL: https://github.com/apache/iotdb/pull/17055#discussion_r2715091671
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java:
##########
@@ -623,16 +616,29 @@ private void moveToNextChunkReader()
}
}
- private boolean filterChunk(final ChunkHeader chunkHeader, final boolean
isAligned)
+ private boolean filterChunk(
+ final long currentChunkHeaderOffset,
+ final ChunkHeader chunkHeader,
+ final boolean isAligned,
+ final byte marker)
throws IOException, IllegalPathException {
- long currentChunkHeaderOffset = tsFileSequenceReader.position() - 1;
final long nextMarkerOffset = tsFileSequenceReader.position() +
chunkHeader.getDataSize();
if (Objects.isNull(currentDevice)) {
tsFileSequenceReader.position(nextMarkerOffset);
return true;
}
+ if (!isAligned) {
+ if ((chunkHeader.getChunkType() & TsFileConstant.TIME_COLUMN_MASK)
+ == TsFileConstant.TIME_COLUMN_MASK) {
+ timeChunkList.add(
+ new Chunk(chunkHeader, tsFileSequenceReader.readChunk(-1,
chunkHeader.getDataSize())));
+ isMultiPageList.add(marker == MetaMarker.TIME_CHUNK_HEADER);
+ return true;
+ }
+ }
Review Comment:
This is weird, nonaligned chunk should not have time column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
