JackieTien97 commented on code in PR #17064:
URL: https://github.com/apache/iotdb/pull/17064#discussion_r2719824343
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/aggregation/Utils.java:
##########
@@ -103,6 +113,26 @@ public static byte[] serializeTimeValue(
return valueBytes;
}
+ public static byte[] serializeTimeValueWithNull(
+ TSDataType seriesDataType,
+ long time,
+ boolean valueIsNull,
+ boolean isOrderTimeNull,
+ TsPrimitiveType value) {
+ // Allocate buffer: fixed header size (10 bytes) + dynamic value size if
present
+ byte[] valueBytes =
+ valueIsNull ? new byte[10] : new byte[10 +
calcTypeSize(seriesDataType, value)];
+ BytesUtils.longToBytes(time, valueBytes, 0);
+ BytesUtils.boolToBytes(valueIsNull, valueBytes, 8);
+ BytesUtils.boolToBytes(isOrderTimeNull, valueBytes, 9);
Review Comment:
```suggestion
BytesUtils.boolToBytes(isOrderTimeNull, valueBytes, 8);
BytesUtils.boolToBytes(valueIsNull, valueBytes, 9);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]