CritasWang commented on code in PR #17099:
URL: https://github.com/apache/iotdb/pull/17099#discussion_r2735392283
##########
external-service-impl/mqtt/pom.xml:
##########
@@ -34,6 +34,17 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
<dependencies>
+ <dependency>
Review Comment:
Does MQTT not need to be changed
##########
integration-test/pom.xml:
##########
@@ -239,6 +239,20 @@
<!--We will integrate mqtt-jar-with-dependencies into lib by
assembly plugin-->
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.iotdb</groupId>
+ <artifactId>rest</artifactId>
+ <version>2.0.7-SNAPSHOT</version>
+ <!--We will integrate rest-jar-with-dependencies into lib by
assembly plugin-->
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
Review Comment:
Confirm if this is needed
##########
integration-test/src/assembly/mpp-share.xml:
##########
@@ -35,5 +35,13 @@
<source>${project.basedir}/../external-service-impl/mqtt/target/mqtt-${project.version}-jar-with-dependencies.jar</source>
<outputDirectory>lib</outputDirectory>
</file>
+ <file>
+
<source>${project.basedir}/../external-service-impl/rest/target/rest-${project.version}-jar-with-dependencies.jar</source>
+ <outputDirectory>lib</outputDirectory>
+ </file>
+ <file>
Review Comment:
Confirm if this is needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
