JackieTien97 opened a new pull request, #17159: URL: https://github.com/apache/iotdb/pull/17159
This pull request introduces improvements to test utilities and refines SQL dialect handling to enhance reliability and maintainability. The main changes include extracting a reusable table result set comparison method, updating integration tests to use this utility, and optimizing dialect switching logic in the client session. **Test utility improvements:** * Extracted the core table result set comparison logic into a new reusable method `tableResultSetEqual`, simplifying `tableResultSetEqualTest` and improving code reuse in test assertions (`TestUtils.java`). [[1]](diffhunk://#diff-6efe0dd713ce5be5c7ea86f8694ea498481530afe2fa3aa2fcdcbbf3642013b3R290-R304) [[2]](diffhunk://#diff-6efe0dd713ce5be5c7ea86f8694ea498481530afe2fa3aa2fcdcbbf3642013b3L309-L314) * Updated imports and usages in `IoTDBFillTableIT.java` to utilize the new `tableResultSetEqual` method, streamlining test code and reducing duplication. [[1]](diffhunk://#diff-1cad616625eaf99043e7ab0c7aacd265bc92f7da729a3f0e422345d70e791b44R26) [[2]](diffhunk://#diff-1cad616625eaf99043e7ab0c7aacd265bc92f7da729a3f0e422345d70e791b44R35-R44) * Refactored the `normalFillTest` method in `IoTDBFillTableIT.java` to use the new utility for direct result set validation, improving clarity and error handling. **SQL dialect handling:** * Optimized the `setSqlDialectAndClean` method in `IClientSession.java` to avoid unnecessary operations when the dialect is unchanged, preventing redundant resets and potential side effects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
