Caideyipi commented on code in PR #17079:
URL: https://github.com/apache/iotdb/pull/17079#discussion_r2929555852
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/schema/ClusterSchemaManager.java:
##########
@@ -1492,12 +1498,37 @@ public synchronized Pair<TSStatus, TsTable>
tableCheckForRenaming(
null);
}
+ if (!originalTable.canAlterName()) {
+ return new Pair<>(
+ RpcUtils.getStatus(
+ TSStatusCode.SEMANTIC_ERROR,
+ String.format(
+ "Table '%s.%s' is created in a old version and cannot be
renamed, "
Review Comment:
an
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/client/DispatchLogHandler.java:
##########
@@ -106,7 +106,7 @@ public void onError(Exception exception) {
++retryCount;
Throwable rootCause = ExceptionUtils.getRootCause(exception);
logger.warn(
- "Can not send {} to peer for {} times {} because {}",
+ "v {} to peer for {} times {} because {}",
Review Comment:
...
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/table/RenameTableColumnPlan.java:
##########
@@ -19,58 +19,61 @@
package org.apache.iotdb.confignode.consensus.request.write.table;
+import org.apache.iotdb.commons.utils.IOUtils;
import org.apache.iotdb.confignode.consensus.request.ConfigPhysicalPlanType;
-import org.apache.tsfile.utils.ReadWriteIOUtils;
-
import java.io.DataOutputStream;
import java.io.IOException;
import java.nio.ByteBuffer;
+import java.util.List;
public class RenameTableColumnPlan extends AbstractTablePlan {
- private String oldName;
- private String newName;
+ private List<String> oldNames;
+ private List<String> newNames;
Review Comment:
May better use "PlanV2" to avoid the stale raft log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
