zerolbsony commented on code in PR #17279:
URL: https://github.com/apache/iotdb/pull/17279#discussion_r2944031281
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/service/ConfigNode.java:
##########
@@ -110,6 +116,13 @@ public class ConfigNode extends ServerCommandLine
implements ConfigNodeMBean {
private int exitStatusCode = 0;
+ private Future<Void> dataPartitionTableCheckFuture;
+
+ private ExecutorService dataPartitionTableCheckExecutor =
+
IoTDBThreadPoolFactory.newSingleThreadExecutor("DATA_PARTITION_TABLE_CHECK");
Review Comment:
The executor will be shut down after it have done.
`protected void start() throws IoTDBException {
try {
// Do ConfigNode startup checks
LOGGER.info("Starting IoTDB {}", IoTDBConstant.VERSION_WITH_BUILD);
ConfigNodeStartupCheck checks = new
ConfigNodeStartupCheck(IoTDBConstant.CN_ROLE);
checks.startUpCheck();
} catch (StartupException | ConfigurationException | IOException e) {
LOGGER.error("Meet error when doing start checking", e);
throw new IoTDBException("Error starting", -1);
}
active();
LOGGER.info("IoTDB started");
if (dataPartitionTableCheckFuture != null) {
try {
dataPartitionTableCheckFuture.get();
} catch (ExecutionException | InterruptedException e) {
LOGGER.error("Data partition table check task execute failed", e);
} finally {
dataPartitionTableCheckExecutor.shutdownNow();
}
}
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
