Eliaaazzz opened a new pull request, #17380: URL: https://github.com/apache/iotdb/pull/17380
Addresses #17337 ## Description This PR adds support for `GROUP BY ALL` in Table Model relational queries. `GROUP BY ALL` infers grouping keys from non-aggregate and non-window expressions in the `SELECT` list, which improves query ergonomics and reduces duplicated grouping expressions in common aggregation queries. This PR also keeps `date_bin_gapfill(...)` behavior consistent under `GROUP BY ALL`, including existing validation for multiple gapfill expressions. <hr> This PR has: - [x] been self-reviewed. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage. <hr> ##### Key changed/added classes (or packages if there are too many classes) in this PR - `iotdb-core/relational-grammar/src/main/antlr4/org/apache/iotdb/db/relational/grammar/sql/RelationalSql.g4` - `iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/parser/AstBuilder.java` - `iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/GroupBy.java` - `iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java` - `iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/util/SqlFormatter.java` - `iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/GroupByAllTest.java` Tested with: - `./mvnw.cmd -pl iotdb-core/datanode -Dtest=GroupByAllTest test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
