Caideyipi opened a new pull request, #17609:
URL: https://github.com/apache/iotdb/pull/17609
## Description
1. In Simple mode, a successful response will be returned stating "Metadata
has taken effect, but WAL has not been flushed to disk." Configuration changes
will be lost after a restart.
2. In the Simple mode, some files have the same sorting key, posing a risk
of log replay in disorder.
3. The return TSStatus of ConsensusManager.write() is not checked, and the
exception is only a warn followed by proceeding to the success branch. This
means that if consensus writing is rejected, redirected, or the state machine
returns a failure, the caller will still receive ACCEPT, while the local
heartbeat cache/metrics have already been created in advance, leading to a
divergence between metadata and runtime states.
4. The value returned by getRegionGroupCount() increases by 1 every time it
is counted, and this value is used for capacity expansion judgment, display,
and maxRegionGroupNum calculation, which directly affects the region scaling
decision.
5. When taking a snapshot, the regionMaintainTaskList lock is not acquired
before traversing. Concurrent offer/poll may throw
ConcurrentModificationException or put the maintenance queue snapshot into an
inconsistent state.
6. If the pipe listener fails to process the snapshot, the entire
takeSnapshot() method will return false; however, ConfigRegionStateMachine
combines and absorbs the failures of loadSnapshot and the pipe listener, which
can amplify auxiliary link failures into consensus snapshot failures, and even
mask the real failure of snapshot loading.
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are
corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes,
inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods,
parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of
emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative
name) for every design
(or naming) decision point and compare the alternatives with the designs
that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen
designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in
this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development
mailing list),
link to that discussion from this PR description and explain what have
changed in your final design
compared to your original proposal or the consensus version in the end of
the discussion.
If something hasn't changed since the original discussion, you can omit a
detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for
the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small
changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items
apply to every PR. Remove the items which are not done or not relevant to
the PR. None of the items
from the checklist above are strictly necessary, but it would be very
helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes)
in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
