Cool6689 opened a new pull request, #17656:
URL: https://github.com/apache/iotdb/pull/17656
This pull request introduces support for the M4 table function in the query
engine, enabling advanced time-series windowing operations (such as time-based
and count-based window modes) and adds comprehensive integration and unit tests
for this functionality. The changes ensure that the query planner can correctly
recognize and process the M4 function, infer its window mode, and handle
argument validation robustly.
The most important changes are:
**M4 Table Function Integration:**
* Registered the `M4TableFunction` as a built-in table function in
`TableBuiltinTableFunction`, enabling its use in SQL queries and ensuring it is
instantiated correctly in the query engine.
[[1]](diffhunk://#diff-3c8d80b1487ae585a3cfd42dcf6ed907f22a56fa84a1c662ed023a126f8a2c2fR28)
[[2]](diffhunk://#diff-3c8d80b1487ae585a3cfd42dcf6ed907f22a56fa84a1c662ed023a126f8a2c2fR46)
[[3]](diffhunk://#diff-3c8d80b1487ae585a3cfd42dcf6ed907f22a56fa84a1c662ed023a126f8a2c2fR91-R92)
[[4]](diffhunk://#diff-008f8fd050d265742d7db8190d6a0c18f7dea2a1163b98402439ef3947603e28R122)
**Query Planner Enhancements:**
* Updated the `StatementAnalyzer` to automatically infer and append the
window mode (time-based or count-based) for the M4 table function, based on the
type of the `SIZE` argument, and to validate required arguments.
**Testing Improvements:**
* Added a comprehensive integration test suite
(`IoTDBM4TableFunctionIT.java`) that covers various use cases, including time
and count window modes, argument validation, and error handling for the M4
table function.
* Expanded unit tests in `TableFunctionTest.java` to verify correct plan
generation for both time and count window modes of the M4 function, as well as
proper error handling for missing required arguments.
[[1]](diffhunk://#diff-829a96c478473febec9880de940889bc641477b5d8e4f37919dfb194db70e9baR49)
[[2]](diffhunk://#diff-829a96c478473febec9880de940889bc641477b5d8e4f37919dfb194db70e9baR229-R307)…lyzer
## Description
### Content1 ...
### Content2 ...
### Content3 ...
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are
corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes,
inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods,
parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of
emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative
name) for every design
(or naming) decision point and compare the alternatives with the designs
that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen
designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in
this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development
mailing list),
link to that discussion from this PR description and explain what have
changed in your final design
compared to your original proposal or the consensus version in the end of
the discussion.
If something hasn't changed since the original discussion, you can omit a
detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for
the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small
changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items
apply to every PR. Remove the items which are not done or not relevant to
the PR. None of the items
from the checklist above are strictly necessary, but it would be very
helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes)
in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
