Caideyipi commented on PR #17770: URL: https://github.com/apache/iotdb/pull/17770#issuecomment-4543739458
Handled the review items in c16fa23 and 4879c3a: - Fixed DefaultOperationQuota for bitMaps == null and sparse bitmap arrays, including InsertMultiTabletsStatement. Added DefaultOperationQuotaTest for both cases. - Centralized compactBitMaps into BitMapUtils and made InsertTabletNode, RelationalInsertTabletNode, InsertTabletStatement, and PipeTabletUtils delegate to the same implementation. - Removed redundant empty bitmap initialization from TsFile parser tablet builders. markNullValue now creates the bitmap array and per-column bitmap lazily only when a null is recorded. - Migrated PipeRowCollector to the same lazy bitmap path and compact before emitting the collected tablet. - Added a bounds guard in PipeRow.isNull for sparse bitmap arrays. For the string-intern scope comment: raw req carries a single tablet, so a per-raw-request pool is enough there; batch req already reuses one pool across all tablets in the batch. For rolling compatibility: null bitMaps are still represented by the existing hasBitMaps=false branch, and the quota path now skips both null arrays and null slots. Verified: - git diff --check - mvn -pl iotdb-core/datanode -DskipTests spotless:apply - mvn -pl iotdb-core/datanode -Dtest=DefaultOperationQuotaTest test - mvn -pl iotdb-core/datanode -Dtest=WritePlanNodeSplitTest test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
