luoluoyuyu commented on code in PR #17665:
URL: https://github.com/apache/iotdb/pull/17665#discussion_r3309342369
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/metric/schema/PipeSchemaRegionSinkMetrics.java:
##########
@@ -72,6 +74,38 @@ private void createRate(final String taskID) {
String.valueOf(connector.getCreationTime())));
}
+ private void createHistogram(final String taskID) {
+ final PipeSinkSubtask connector = connectorMap.get(taskID);
+
+ final Histogram schemaBatchSizeHistogram =
+ metricService.getOrCreateHistogram(
+ Metric.PIPE_SCHEMA_BATCH_SIZE.toString(),
+ MetricLevel.IMPORTANT,
+ Tag.NAME.toString(),
+ connector.getAttributeSortedString(),
+ Tag.CREATION_TIME.toString(),
+ String.valueOf(connector.getCreationTime()));
+ connector.setTabletBatchSizeHistogram(schemaBatchSizeHistogram);
Review Comment:
Schema 批大小 histogram 调用了 connector.setTabletBatchSizeHistogram(...)，但 metric
名是 PIPE_SCHEMA_BATCH_SIZE。
建议：增加 setSchemaBatchSizeHistogram 专用 setter，或在注释标明 tablet 接口承载 schema 指标，避免
Grafana 误读。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
