luoluoyuyu commented on code in PR #17670:
URL: https://github.com/apache/iotdb/pull/17670#discussion_r3309377018
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/consensus/statemachine/dataregion/DataExecutionVisitor.java:
##########
@@ -75,7 +75,6 @@ public TSStatus
visitRelationalInsertRows(RelationalInsertRowsNode node, DataReg
public TSStatus visitInsertRow(InsertRowNode node, DataRegion dataRegion) {
try {
dataRegion.insert(node);
- dataRegion.insertSeparatorToWAL();
return StatusUtils.OK;
Review Comment:
Removing insertSeparatorToWAL after each insert* visit is the core behavior
change. Please document how batch boundaries are now inferred on replay and
verify all insert plan types that previously relied on separators are covered.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertRowNode.java:
##########
@@ -619,7 +619,7 @@ private int serializeMeasurementsAndValuesSize() {
@Override
public void serializeToWAL(IWALByteBufferView buffer) {
buffer.putShort(getType().getNodeType());
- buffer.putLong(searchIndex);
+ buffer.putLong(getEncodedSearchIndex());
Review Comment:
serializeToWAL now uses getEncodedSearchIndex instead of searchIndex.
Confirm deserializeFromWAL and mixed-version clusters read old WAL entries
correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
