luoluoyuyu commented on code in PR #17674:
URL: https://github.com/apache/iotdb/pull/17674#discussion_r3309379962
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/converter/LoadTreeStatementDataTypeConvertExecutionVisitor.java:
##########
@@ -89,16 +87,9 @@ public Optional<TSStatus> visitLoadFile(
try {
for (final File file : loadTsFileStatement.getTsFiles()) {
- try (final TsFileInsertionEventScanParser parser =
- new TsFileInsertionEventScanParser(
- file,
- new IoTDBTreePattern(null),
- Long.MIN_VALUE,
- Long.MAX_VALUE,
- null,
- null,
- true)) {
- for (final Pair<Tablet, Boolean> tabletWithIsAligned :
parser.toTabletWithIsAligneds()) {
+ try (final LoadTreeTsFileTabletIterator tabletIterator =
Review Comment:
Replacing TsFileInsertionEventScanParser with LoadTreeTsFileTabletIterator
centralizes corrupted-file handling for load. Please document what data may
still be skipped versus inserted when a file is partially corrupted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
