Caideyipi commented on PR #17672: URL: https://github.com/apache/iotdb/pull/17672#issuecomment-4572207019
Addressed the review comments in commit 2a68c3842fa: - Made IMNodeIterator AutoCloseable and converted the new iterator scans to try-with-resources. - Reduced the Sonar duplication from repeated flag delegate methods by moving the shared accessors to default methods on IMemMNode / ICachedMNode. - Added coverage for delete refresh correctness when one device subtree is removed while another sibling device subtree still exists, plus table-device drop coverage in memory mode. Verification: - mvn -pl iotdb-core/datanode,iotdb-core/node-commons spotless:apply - MAVEN_OPTS=-Xmx768m mvn -Ddevelocity.off=true -Dcheckstyle.skip=true -Dspotless.check.skip=true -pl iotdb-core/node-commons,iotdb-core/datanode -Dtest=MTreeBelowSGMemoryImplTest,MTreeBelowSGCachedImplTest -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false test For current CI: the latest failing Simple (17) job failed during ctions/checkout with a GitHub TLS fetch error before build/test. The dual-tree-auto-basic failure is in IoTDBPipeLifeCycleIT.testLifeCycleLogMode, unrelated to this schema flag change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
