Caideyipi commented on PR #17609: URL: https://github.com/apache/iotdb/pull/17609#issuecomment-4608894210
Addressed the review feedback and pushed the updates. Changes: - Added WAL rollback/replay coverage: failed SimpleConsensus writes now assert that the rolled-back WAL contains no replayable plan. - Added idempotency coverage for replay-relevant NodeInfo plans touched by this PR: RegisterDataNodePlan, ApplyConfigNodePlan, and UpdateVersionInfoPlan. - Improved SimpleConsensus rollback failure logging with plan type, log file, truncate offset, and endIndexBeforeWrite; the returned status now also notes that the persisted plan may replay after restart if rollback fails. - Removed newly introduced TODO comments; todo-check is now passing. - Merged latest master and resolved the PartialPath conflict by keeping master's implementation, so the PR is mergeable again. Verification: - mvn -pl iotdb-core/confignode spotless:apply - mvn -pl iotdb-core/node-commons spotless:apply - mvn -pl iotdb-core/confignode '-Dtest=ConfigRegionStateMachineTest,NodeInfoTest' test - git diff --check origin/master...HEAD Current CI note: the Simple (17) failures were checkout/network failures on self-hosted runners (gnutls_handshake before tests started). I reran the failed jobs. todo-check has passed; the remaining jobs are still pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
