jt2594838 commented on code in PR #17815:
URL: https://github.com/apache/iotdb/pull/17815#discussion_r3346943527
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java:
##########
@@ -860,6 +875,29 @@ private TSStatus executeStatementAndClassifyExceptions(
}
}
+ private void logStatementExceptionIfNecessary(final Statement statement,
final Exception e) {
+ if (shouldLogStatementException(receiverId.get(), statement, e)) {
+ PipeLogger.log(
+ LOGGER::warn,
+ e,
+ "Receiver id = %s: Exception encountered while executing statement
%s: ",
+ receiverId.get(),
+ Objects.isNull(statement) ? null : statement.getPipeLoggingString());
+ }
+ }
+
+ static boolean shouldLogStatementException(
+ final long receiverId, final Statement statement, final Exception e) {
+ // Use the reducer cache as a gate. The actual stack trace is logged only
when it passes.
+ return PipePeriodicalLogReducer.log(
+ message -> {},
+ "Receiver id = %s, statement = %s, exception = %s, message = %s",
Review Comment:
i18n?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
