DaZuiZui commented on PR #17810: URL: https://github.com/apache/iotdb/pull/17810#issuecomment-4624534104
Thanks for the review! I have addressed the latest Copilot comments in this PR: 1. Added an explicit `requireNonNull(fillMethod, "fillMethod is null")` check in the `Fill` constructor before comparing the fill policy. 2. Removed the redundant `groupSplitter` state from `TableNextFillWithGroupOperator`, including its field, initialization, and add/remove bookkeeping. The grouped NEXT fill reset logic still relies on `noMoreTsBlockForCurrentGroup`, so the existing behavior is preserved. I also verified the related test with: `mvn test -pl iotdb-core/datanode -am -Dtest=NextFillTest -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false -DskipITs` Result: `Tests run: 5, Failures: 0, Errors: 0, Skipped: 0`, `BUILD SUCCESS`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
