VGalaxies commented on PR #17780: URL: https://github.com/apache/iotdb/pull/17780#issuecomment-4645990724
Addressed the lease-transfer review comment in 82049d7b46. Topic ownership transfer now checks the current topic owner lease before replacing owner metadata: if the current owner has an unexpired `owner-lease-expire-time-ms` and the incoming owner id is different, the transfer is rejected. Once the lease has expired, the transfer can proceed. Added `SubscriptionInfoTest` coverage for both paths. Also addressed the inline comments in the same commit: - public session `alterTopic(...)` rejects owner attributes; `alterTopicOwner(...)` is the session API entry for owner updates. - removed the extra deep copy from the alter-topic metadata build path. - moved the two hard-coded messages to en/zh i18n constants. Local verification passed: - `mvn spotless:apply -pl iotdb-client/subscription,iotdb-core/node-commons,iotdb-core/confignode,iotdb-core/datanode -DskipTests` - `mvn test -pl iotdb-protocol/thrift-confignode,iotdb-client/service-rpc,iotdb-client/subscription,iotdb-core/node-commons,iotdb-core/confignode -Dtest=SubscriptionInfoTest -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false` - `mvn test -pl iotdb-protocol/thrift-confignode,iotdb-core/relational-grammar,iotdb-client/service-rpc,iotdb-client/subscription,iotdb-core/node-commons,iotdb-core/datanode -Dtest=StatementGeneratorTest -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false` - `mvn compile -pl iotdb-protocol/thrift-confignode,iotdb-client/service-rpc,iotdb-client/subscription,iotdb-core/relational-grammar,iotdb-core/node-commons,iotdb-core/confignode,iotdb-core/datanode -P with-zh-locale -DskipTests` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
