Caideyipi opened a new pull request, #17872:
URL: https://github.com/apache/iotdb/pull/17872

   ## Description
   
   This PR tightens several queue/semaphore invariants:
   
   - reject non-positive capacities in IndexedBlockingQueue and 
FixedPriorityBlockingQueue
   - reject duplicate IDs before mutating indexed queue state
   - reject reserve queue repush/decrease operations when no reserved slot 
exists
   - reject negative capacity or initial permits in FiniteSemaphore
   - add focused unit coverage for the above cases
   
   ## Tests
   
   - mvn -pl iotdb-core/calc-commons -DskipTests spotless:apply
   - java -Xmx128m -cp ... org.junit.runner.JUnitCore 
org.apache.iotdb.calc.execution.schedule.queue.IndexedBlockingQueueTest
   - java -Xms8m -Xmx32m -XX:+UseSerialGC -XX:ReservedCodeCacheSize=8m -cp ... 
org.junit.runner.JUnitCore 
org.apache.iotdb.db.utils.datastructure.FixedPriorityBlockingQueueTest
   - java -Xms8m -Xmx32m -XX:+UseSerialGC -XX:ReservedCodeCacheSize=8m -cp ... 
org.junit.runner.JUnitCore 
org.apache.iotdb.db.utils.concurrent.FiniteSemaphoreTest
   
   Note: a later mvn -pl iotdb-core/datanode -DskipTests spotless:apply attempt 
could not start the JVM on this Windows machine because the page file/native 
memory was exhausted. git diff --check passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to