jt2594838 opened a new pull request, #17899:
URL: https://github.com/apache/iotdb/pull/17899
## Description
This PR adds a configurable cache for
`PathUtils#checkAndReturnSingleMeasurement` so repeated measurement validation
can reuse previous check results. The cache stores both valid and invalid
validation results and can be disabled by setting the cache size to `0`.
It also adds configuration plumbing for integration tests and an ignored
performance IT that can be run manually to compare end-to-end write performance
with the cache disabled and enabled.
## Test Report
Local verification:
```text
mvn spotless:apply -pl integration-test -P with-integration-tests
mvn spotless:apply -pl iotdb-core/datanode
mvn test-compile -DskipUTs -Drat.skip=true -pl integration-test -am -P
with-integration-tests
```
Remote performance verification on `192.168.130.12` under `/data/jt/iotdb`:
```text
/data/jt/apache-maven-3.9.11/bin/mvn -o verify \
-DskipUTs \
-Dit.test=IoTDBSingleMeasurementCheckCachePerformanceIT \
-DfailIfNoTests=false \
-Dfailsafe.failIfNoSpecifiedTests=false \
-Drat.skip=true \
-pl integration-test -am -P with-integration-tests
```
Remote IT result:
```text
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
Time elapsed: 285.5 s
```
Remote performance averages, 3 repeats per group, 80,000 rows per experiment:
| measurementCount | cacheSize | Relation | Cache Disabled | Cache Enabled |
Enabled/Disabled |
|---:|---:|---|---:|---:|---:|
| 1000 | 500 | cacheSize < measurementCount | 4794 ms | 4384 ms | 0.914 |
| 2000 | 2000 | cacheSize = measurementCount | 9676 ms | 8255 ms | 0.853 |
| 4000 | 8000 | cacheSize > measurementCount | 19980 ms | 17223 ms | 0.862 |
Remote report files:
```text
/data/jt/iotdb/remote-performance-it.log
/data/jt/iotdb/integration-test/target/failsafe-reports/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
