Copilot commented on code in PR #17859:
URL: https://github.com/apache/iotdb/pull/17859#discussion_r3392441131
##########
scripts/sbin/windows/start-datanode.bat:
##########
@@ -48,15 +48,11 @@ for /f tokens^=2-5^ delims^=.-_+^" %%j in ('java
-fullversion 2^>^&1') do (
set JAVA_VERSION=%MAJOR_VERSION%
-@REM we do not check jdk that version less than 1.8 because they are too
stale...
-IF "%JAVA_VERSION%" == "6" (
- echo IoTDB only supports jdk >= 8, please check your java version.
- goto finally
-)
-IF "%JAVA_VERSION%" == "7" (
- echo IoTDB only supports jdk >= 8, please check your java version.
- goto finally
-)
+ @REM IoTDB requires JDK 17 or later.
+ IF %JAVA_VERSION% LSS 17 (
+ echo IoTDB only supports jdk >= 17, please check your java
version.
+ goto finally
+ )
Review Comment:
The numeric JDK version check will fail with a syntax error if JAVA_VERSION
is empty (e.g., if `java -fullversion` cannot be executed and the version parse
loop never sets MAJOR_VERSION). Add an explicit empty-check before the `LSS`
comparison so the script fails gracefully with a clear message instead of `LSS
was unexpected at this time`.
##########
scripts/sbin/windows/start-confignode.bat:
##########
@@ -46,15 +46,11 @@ for /f tokens^=2-5^ delims^=.-_+^" %%j in ('java
-fullversion 2^>^&1') do (
set JAVA_VERSION=%MAJOR_VERSION%
-@REM we do not check jdk that version less than 1.8 because they are too
stale...
-IF "%JAVA_VERSION%" == "6" (
- echo IoTDB only supports jdk >= 8, please check your java version.
- goto finally
-)
-IF "%JAVA_VERSION%" == "7" (
- echo IoTDB only supports jdk >= 8, please check your java version.
- goto finally
-)
+ @REM IoTDB requires JDK 17 or later.
+ IF %JAVA_VERSION% LSS 17 (
+ echo IoTDB only supports jdk >= 17, please check your java
version.
+ goto finally
+ )
Review Comment:
Same as DataNode: `IF %JAVA_VERSION% LSS 17` will break if JAVA_VERSION is
empty (e.g., if `java -fullversion` fails and MAJOR_VERSION stays unset). Add
an explicit empty-check before the numeric comparison to avoid a cmd parse
error and provide a clearer failure mode.
##########
LICENSE-binary:
##########
@@ -224,12 +224,12 @@ com.fasterxml.jackson.core:jackson-databind:2.16.2
jakarta.inject:jakarta.inject:2.6.1
at.yawk.lz4:lz4-java:1.10.0
com.github.ben-manes.caffeine:caffeine:2.9.3
-org.eclipse.jetty:jetty-http:9.4.58.v20250814
-org.eclipse.jetty:jetty-io:9.4.58.v20250814
-org.eclipse.jetty:jetty-security:9.4.58.v20250814
-org.eclipse.jetty:jetty-server:9.4.58.v20250814
-org.eclipse.jetty:jetty-servlet:9.4.58.v20250814
-org.eclipse.jetty:jetty-util:9.4.58.v20250814
+org.eclipse.jetty:jetty-http:12.0.36
+org.eclipse.jetty:jetty-io:12.0.36
+org.eclipse.jetty:jetty-security:12.0.36
+org.eclipse.jetty:jetty-server:12.0.36
+org.eclipse.jetty.ee10:jetty-ee10-servlet:12.0.36
+org.eclipse.jetty:jetty-util:12.0.36
Review Comment:
Jetty 12 introduces additional split-out artifacts (e.g., `jetty-session`)
and this repo’s dependency inventory already includes
`org.eclipse.jetty:jetty-session`. If the binary distribution bundles it
transitively (which is typical when using `jetty-ee10-servlet`), it should also
be listed in LICENSE-binary alongside the other Jetty modules.
##########
dependencies.json:
##########
@@ -1,160 +1,163 @@
{
- "dependencies": [
- "at.yawk.lz4:lz4-java",
- "cglib:cglib",
- "ch.qos.logback:logback-classic",
- "ch.qos.logback:logback-core",
- "ch.qos.reload4j:reload4j",
- "com.digitalpetri.fsm:strict-machine",
- "com.digitalpetri.netty:netty-channel-fsm",
- "com.fasterxml.jackson.core:jackson-annotations",
- "com.fasterxml.jackson.core:jackson-core",
- "com.fasterxml.jackson.core:jackson-databind",
- "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml",
- "com.fasterxml.jackson.datatype:jackson-datatype-jsr310",
- "com.fasterxml.jackson.jaxrs:jackson-jaxrs-base",
- "com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider",
- "com.fasterxml.jackson.module:jackson-module-jaxb-annotations",
- "com.github.ben-manes.caffeine:caffeine",
- "com.github.luben:zstd-jni",
- "com.github.moquette-io.moquette:moquette-broker",
- "com.github.wendykierp:JTransforms",
- "com.google.code.findbugs:jsr305",
- "com.google.code.gson:gson",
- "com.google.errorprone:error_prone_annotations",
- "com.google.guava:failureaccess",
- "com.google.guava:guava",
- "com.google.guava:listenablefuture",
- "com.google.j2objc:j2objc-annotations",
- "com.h2database:h2-mvstore",
- "com.sun.istack:istack-commons-runtime",
- "com.zaxxer:HikariCP",
- "commons-cli:commons-cli",
- "commons-codec:commons-codec",
- "commons-logging:commons-logging",
- "io.airlift:airline",
- "io.airlift:units",
- "io.dropwizard.metrics:metrics-core",
- "io.micrometer:micrometer-commons",
- "io.micrometer:micrometer-core",
- "io.micrometer:micrometer-observation",
- "io.netty:netty-buffer",
- "io.netty:netty-codec",
- "io.netty:netty-codec-dns",
- "io.netty:netty-codec-http",
- "io.netty:netty-codec-http2",
- "io.netty:netty-codec-mqtt",
- "io.netty:netty-codec-socks",
- "io.netty:netty-common",
- "io.netty:netty-handler",
- "io.netty:netty-handler-proxy",
- "io.netty:netty-resolver",
- "io.netty:netty-resolver-dns",
- "io.netty:netty-resolver-dns-classes-macos",
- "io.netty:netty-resolver-dns-native-macos",
- "io.netty:netty-tcnative-boringssl-static",
- "io.netty:netty-tcnative-boringssl-static",
- "io.netty:netty-tcnative-boringssl-static",
- "io.netty:netty-tcnative-boringssl-static",
- "io.netty:netty-tcnative-boringssl-static",
- "io.netty:netty-tcnative-classes",
- "io.netty:netty-transport",
- "io.netty:netty-transport-classes-epoll",
- "io.netty:netty-transport-classes-kqueue",
- "io.netty:netty-transport-native-epoll",
- "io.netty:netty-transport-native-epoll",
- "io.netty:netty-transport-native-kqueue",
- "io.netty:netty-transport-native-kqueue",
- "io.netty:netty-transport-native-unix-common",
- "io.projectreactor:reactor-core",
- "io.projectreactor.netty:reactor-netty-core",
- "io.projectreactor.netty:reactor-netty-http",
- "io.swagger:swagger-annotations",
- "io.swagger:swagger-core",
- "io.swagger:swagger-jaxrs",
- "io.swagger:swagger-models",
- "jakarta.activation:jakarta.activation-api",
- "jakarta.annotation:jakarta.annotation-api",
- "jakarta.servlet:jakarta.servlet-api",
- "jakarta.validation:jakarta.validation-api",
- "jakarta.ws.rs:jakarta.ws.rs-api",
- "jakarta.xml.bind:jakarta.xml.bind-api",
- "javax.xml.bind:jaxb-api",
- "net.java.dev.jna:jna",
- "net.java.dev.jna:jna-platform",
- "org.antlr:antlr4-runtime",
- "org.apache.commons:commons-csv",
- "org.apache.commons:commons-lang3",
- "org.apache.commons:commons-math3",
- "org.apache.commons:commons-pool2",
- "org.apache.httpcomponents:httpclient",
- "org.apache.httpcomponents:httpcore",
- "org.apache.ratis:ratis-client",
- "org.apache.ratis:ratis-common",
- "org.apache.ratis:ratis-grpc",
- "org.apache.ratis:ratis-metrics-api",
- "org.apache.ratis:ratis-proto",
- "org.apache.ratis:ratis-server",
- "org.apache.ratis:ratis-server-api",
- "org.apache.ratis:ratis-thirdparty-misc",
- "org.apache.thrift:libthrift",
- "org.apache.tsfile:common",
- "org.apache.tsfile:tsfile",
- "org.bouncycastle:bcpkix-jdk18on",
- "org.bouncycastle:bcprov-jdk18on",
- "org.bouncycastle:bcutil-jdk18on",
- "org.checkerframework:checker-qual",
- "org.eclipse.collections:eclipse-collections",
- "org.eclipse.collections:eclipse-collections-api",
- "org.eclipse.jetty:jetty-http",
- "org.eclipse.jetty:jetty-io",
- "org.eclipse.jetty:jetty-security",
- "org.eclipse.jetty:jetty-server",
- "org.eclipse.jetty:jetty-servlet",
- "org.eclipse.jetty:jetty-util",
- "org.eclipse.jetty:jetty-util-ajax",
- "org.eclipse.milo:bsd-core",
- "org.eclipse.milo:bsd-generator",
- "org.eclipse.milo:sdk-client",
- "org.eclipse.milo:sdk-core",
- "org.eclipse.milo:sdk-server",
- "org.eclipse.milo:stack-client",
- "org.eclipse.milo:stack-core",
- "org.eclipse.milo:stack-server",
- "org.fusesource.hawtbuf:hawtbuf",
- "org.fusesource.hawtdispatch:hawtdispatch",
- "org.fusesource.hawtdispatch:hawtdispatch-transport",
- "org.fusesource.mqtt-client:mqtt-client",
- "org.glassfish.hk2:hk2-api",
- "org.glassfish.hk2:hk2-locator",
- "org.glassfish.hk2:hk2-utils",
- "org.glassfish.hk2:osgi-resource-locator",
- "org.glassfish.hk2.external:aopalliance-repackaged",
- "org.glassfish.hk2.external:jakarta.inject",
- "org.glassfish.jaxb:jaxb-runtime",
- "org.glassfish.jaxb:txw2",
- "org.glassfish.jersey.containers:jersey-container-servlet-core",
- "org.glassfish.jersey.core:jersey-client",
- "org.glassfish.jersey.core:jersey-common",
- "org.glassfish.jersey.core:jersey-server",
- "org.glassfish.jersey.inject:jersey-hk2",
- "org.glassfish.jersey.media:jersey-media-multipart",
- "org.hdrhistogram:HdrHistogram",
- "org.java-websocket:Java-WebSocket",
- "org.javassist:javassist",
- "org.jline:jline",
- "org.jvnet.mimepull:mimepull",
- "org.latencyutils:LatencyUtils",
- "org.ops4j.pax.jdbc:pax-jdbc-common",
- "org.osgi:osgi.cmpn",
- "org.osgi:osgi.core",
- "org.ow2.asm:asm",
- "org.reactivestreams:reactive-streams",
- "org.slf4j:slf4j-api",
- "org.slf4j:slf4j-reload4j",
- "org.tukaani:xz",
- "org.xerial.snappy:snappy-java",
- "org.yaml:snakeyaml",
- "pl.edu.icm:JLargeArrays"
- ]
+ "dependencies": [
+ "at.yawk.lz4:lz4-java",
+ "cglib:cglib",
+ "ch.qos.logback:logback-classic",
+ "ch.qos.logback:logback-core",
+ "ch.qos.reload4j:reload4j",
+ "com.digitalpetri.fsm:strict-machine",
+ "com.digitalpetri.netty:netty-channel-fsm",
+ "com.fasterxml.jackson.core:jackson-annotations",
+ "com.fasterxml.jackson.core:jackson-core",
+ "com.fasterxml.jackson.core:jackson-databind",
+ "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml",
+ "com.fasterxml.jackson.datatype:jackson-datatype-jsr310",
+ "com.fasterxml.jackson.jakarta.rs:jackson-jakarta-rs-base",
+ "com.fasterxml.jackson.jakarta.rs:jackson-jakarta-rs-json-provider",
+
"com.fasterxml.jackson.module:jackson-module-jakarta-xmlbind-annotations",
+ "com.github.ben-manes.caffeine:caffeine",
+ "com.github.luben:zstd-jni",
+ "com.github.moquette-io.moquette:moquette-broker",
+ "com.github.wendykierp:JTransforms",
+ "com.google.code.findbugs:jsr305",
+ "com.google.code.gson:gson",
+ "com.google.errorprone:error_prone_annotations",
+ "com.google.guava:failureaccess",
+ "com.google.guava:guava",
+ "com.google.guava:listenablefuture",
+ "com.google.j2objc:j2objc-annotations",
+ "com.h2database:h2-mvstore",
+ "com.sun.activation:jakarta.activation",
+ "com.sun.istack:istack-commons-runtime",
+ "com.zaxxer:HikariCP",
+ "commons-cli:commons-cli",
+ "commons-codec:commons-codec",
+ "commons-logging:commons-logging",
+ "io.airlift:airline",
+ "io.airlift:units",
+ "io.dropwizard.metrics:metrics-core",
+ "io.github.classgraph:classgraph",
+ "io.micrometer:micrometer-commons",
+ "io.micrometer:micrometer-core",
+ "io.micrometer:micrometer-observation",
+ "io.netty:netty-buffer",
+ "io.netty:netty-codec",
+ "io.netty:netty-codec-dns",
+ "io.netty:netty-codec-http",
+ "io.netty:netty-codec-http2",
+ "io.netty:netty-codec-mqtt",
+ "io.netty:netty-codec-socks",
+ "io.netty:netty-common",
+ "io.netty:netty-handler",
+ "io.netty:netty-handler-proxy",
+ "io.netty:netty-resolver",
+ "io.netty:netty-resolver-dns",
+ "io.netty:netty-resolver-dns-classes-macos",
+ "io.netty:netty-resolver-dns-native-macos",
+ "io.netty:netty-tcnative-boringssl-static",
+ "io.netty:netty-tcnative-boringssl-static",
+ "io.netty:netty-tcnative-boringssl-static",
+ "io.netty:netty-tcnative-boringssl-static",
+ "io.netty:netty-tcnative-boringssl-static",
+ "io.netty:netty-tcnative-classes",
+ "io.netty:netty-transport",
+ "io.netty:netty-transport-classes-epoll",
+ "io.netty:netty-transport-classes-kqueue",
+ "io.netty:netty-transport-native-epoll",
+ "io.netty:netty-transport-native-epoll",
+ "io.netty:netty-transport-native-kqueue",
+ "io.netty:netty-transport-native-kqueue",
+ "io.netty:netty-transport-native-unix-common",
+ "io.projectreactor:reactor-core",
+ "io.projectreactor.netty:reactor-netty-core",
+ "io.projectreactor.netty:reactor-netty-http",
+ "io.swagger.core.v3:swagger-annotations-jakarta",
+ "io.swagger.core.v3:swagger-core-jakarta",
+ "io.swagger.core.v3:swagger-integration-jakarta",
+ "io.swagger.core.v3:swagger-jaxrs2-jakarta",
+ "io.swagger.core.v3:swagger-models-jakarta",
+ "jakarta.activation:jakarta.activation-api",
+ "jakarta.annotation:jakarta.annotation-api",
+ "jakarta.inject:jakarta.inject-api",
+ "jakarta.servlet:jakarta.servlet-api",
+ "jakarta.validation:jakarta.validation-api",
+ "jakarta.ws.rs:jakarta.ws.rs-api",
+ "jakarta.xml.bind:jakarta.xml.bind-api",
+ "jakarta.xml.bind:jakarta.xml.bind-api",
Review Comment:
`jakarta.xml.bind:jakarta.xml.bind-api` is listed twice. This file is used
to compare against the generated SBOM, so duplicates can create noisy diffs or
false mismatches. Remove the duplicate entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
