jt2594838 commented on PR #17911: URL: https://github.com/apache/iotdb/pull/17911#issuecomment-4679675492
Addressed the review comments in `9501c61631`: 1. `TElasticFramedTransport.close()` now releases the accounted read/write buffers, and compressed transports release their extra compression buffers as well. 2. Constructor failure paths now close any buffers that were already allocated, covering both framed and compressed transports. 3. `Utils.serializeTSStatus()` now copies the serialized bytes and closes the temporary `AutoScalingBufferWriteTransport` in a finally block. 4. ConfigNode startup now initializes `MemoryConfig`, so the ConfigNode RPC path installs the AutoResizingBuffer memory-control hook. 5. Removed the unrelated `AGENTS.md` RAT exclusion from this PR. Also added unit coverage for transport close/failure release paths in `AutoResizingBufferTest`. Validation run: - `mvn spotless:apply -pl iotdb-client/service-rpc,iotdb-core/consensus,iotdb-core/confignode` - `mvn test -pl iotdb-client/service-rpc -Dtest=AutoResizingBufferTest` - `mvn compile -pl iotdb-core/consensus,iotdb-core/confignode -am` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
