JackieTien97 commented on code in PR #17937:
URL: https://github.com/apache/iotdb/pull/17937#discussion_r3412107327


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java:
##########
@@ -2869,6 +2880,9 @@ private Analysis.GroupingSetAnalysis analyzeGroupBy(
                     "%s is not comparable, and therefore cannot be used in 
GROUP BY", type));
           }
         }
+        if (groupBy.isAll()) {
+          validateAllGroupByWindowFunctions(allGroupByExpressions, scope, 
outputExpressions);
+        }

Review Comment:
   SELECT device_id, avg(s1), rank() OVER (ORDER BY s1)
   FROM table1
   GROUP BY device_id



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to