CritasWang commented on code in PR #110:
URL: https://github.com/apache/iotdb-extras/pull/110#discussion_r3449733425
##########
pom.xml:
##########
@@ -2072,6 +2072,21 @@
<argLine>--add-opens=java.base/java.util.concurrent=ALL-UNNAMED
--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens=java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/java.io=ALL-UNNAMED
--add-opens=java.base/java.net=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED</argLine>
</properties>
</profile>
+ <!--
+ The iotdb-thingsboard-table module compiles with release 17 (it uses
records and other
+ Java 17 language features), so it cannot build on the JDK 8/11 reactor
jobs. Gate it behind
+ a JDK 17+ activated profile instead of the default <modules> list so the
8/11 CI jobs skip it
+ while 17/21 still build and test it as part of the reactor.
+ -->
+ <profile>
+ <id>iotdb-thingsboard-table-jdk17</id>
+ <activation>
+ <jdk>[17,)</jdk>
Review Comment:
remove activation
##########
pom.xml:
##########
@@ -2072,6 +2072,21 @@
<argLine>--add-opens=java.base/java.util.concurrent=ALL-UNNAMED
--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens=java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/java.io=ALL-UNNAMED
--add-opens=java.base/java.net=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED</argLine>
</properties>
</profile>
+ <!--
+ The iotdb-thingsboard-table module compiles with release 17 (it uses
records and other
+ Java 17 language features), so it cannot build on the JDK 8/11 reactor
jobs. Gate it behind
+ a JDK 17+ activated profile instead of the default <modules> list so the
8/11 CI jobs skip it
+ while 17/21 still build and test it as part of the reactor.
+ -->
+ <profile>
+ <id>iotdb-thingsboard-table-jdk17</id>
Review Comment:
with-thingsboard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
