Caideyipi opened a new pull request, #17995:
URL: https://github.com/apache/iotdb/pull/17995

   ## Description
   This PR fixes a fragile assertion in SingleDeviceViewOperatorTest. The test 
used to derive the expected timestamp from the TsBlock index and assumed each 
returned block contains 20 rows. The operator contract does not guarantee that 
block size, so when the child operator returns a larger block, the expected 
timestamp resets incorrectly and the test can fail with expected 20 but was 320.
   
   The test now validates timestamps by a global row counter across all 
returned TsBlocks, while preserving the existing value and null-column checks.
   
   This is unrelated to the show receivers changes: the current show-receivers 
branch does not modify SingleDeviceViewOperatorTest, SingleDeviceViewOperator, 
FullOuterTimeJoinOperator, or SeriesReaderTestUtil.
   
   ## Tests
   - mvn -pl iotdb-core/datanode spotless:apply
   - mvn -pl iotdb-core/datanode 
-Dtest=SingleDeviceViewOperatorTest#singleDeviceViewOperatorTest test (not 
completed locally: dependency resolution fails before tests run because 
snapshot artifacts such as org.apache.iotdb:node-commons:2.0.7-SNAPSHOT are 
unavailable from the configured Maven repositories)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to