HTHou commented on code in PR #17987:
URL: https://github.com/apache/iotdb/pull/17987#discussion_r3458775792
##########
iotdb-client/client-cpp/examples/CMakeLists.txt:
##########
@@ -145,6 +167,12 @@ foreach(_t IN LISTS _example_targets)
COMMAND ${CMAKE_COMMAND} -E copy_if_different
"${_iotdb_runtime}" $<TARGET_FILE_DIR:${_t}>
COMMENT "Copy IoTDB runtime library next to ${_t}")
+ foreach(_ssl_lib IN LISTS _iotdb_sdk_ssl_runtime)
Review Comment:
This copies the bundled OpenSSL runtime libraries next to each example
binary, but the `example-dist` target below still only stages the executables
and `iotdb_session`. A user who builds `example-dist` and copies that `dist/`
directory to a machine without OpenSSL will still fail at runtime. Could we
also copy `_iotdb_sdk_ssl_runtime` into `_example_dist_dir` when it is
populated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
