Copilot commented on code in PR #18018:
URL: https://github.com/apache/iotdb/pull/18018#discussion_r3465176465
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/fragment/FragmentInstanceContext.java:
##########
@@ -1264,6 +1273,50 @@ public void addBlockQueuedTime(long time) {
blockQueueTime.addAndGet(time);
}
+ public void recordScanAggregationFromRawDataCost(long costTimeInNanos) {
+ addCost(scanAggregationFromRawDataCost, costTimeInNanos);
+ }
+
+ public void recordScanAggregationFromStatisticsCost(long costTimeInNanos) {
+ addCost(scanAggregationFromStatisticsCost, costTimeInNanos);
+ }
+
+ public void recordAggregationOperatorFromRawDataCost(long costTimeInNanos) {
+ addCost(aggregationOperatorFromRawDataCost, costTimeInNanos);
+ }
+
+ private void addCost(AtomicLong cost, long costTimeInNanos) {
+ if (costTimeInNanos > 0) {
+ cost.addAndGet(costTimeInNanos);
+ }
+ }
+
+ long drainScanAggregationFromRawDataCost() {
+ return scanAggregationFromRawDataCost.getAndSet(0);
+ }
+
+ long drainScanAggregationFromStatisticsCost() {
+ return scanAggregationFromStatisticsCost.getAndSet(0);
+ }
+
+ long drainAggregationOperatorFromRawDataCost() {
+ return aggregationOperatorFromRawDataCost.getAndSet(0);
+ }
+
+ @TestOnly
+ void recordAggregationCostToMetric() {
Review Comment:
`recordAggregationCostToMetric()` is annotated with `@TestOnly` but is
invoked from `releaseResource()` (production path). This annotation can mislead
readers and may be flagged by static analysis; consider removing it (or
splitting into a production method plus a test-only wrapper).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
