Caideyipi commented on PR #18023: URL: https://github.com/apache/iotdb/pull/18023#issuecomment-4795410968
Closing this PR after re-checking the intended behavior. The current definition is: if the identifier was stored with backquotes and those backquotes are preserved in the stored path representation, SHOW should output them; otherwise SHOW should not add backquotes by itself. Existing path handling already follows that rule: PartialPath/PathUtils removes backquotes for identifiers that can be represented directly, and preserves them for cases that require them (for example numeric or dotted identifiers). The current IT expectations, including root.sg1.d1.123d staying unquoted, match that behavior. This PR mainly changes display code to add SQL-safe backquotes at output time (for example reserved words / parser-sensitive identifiers), which is a broader compatibility change and caused the observed IoTDBSyntaxConventionIdentifierIT failure. I also checked the active region scan path: the old IDeviceID.toString() joins the stored device-id segments, so it does not by itself justify keeping the new display-path map, since the map is also generated with display-time quoting. So there is no narrow fix in this PR that should be kept under the current feature definition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
