Caideyipi commented on code in PR #18010:
URL: https://github.com/apache/iotdb/pull/18010#discussion_r3472891182
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java:
##########
@@ -859,22 +808,38 @@ private boolean filterChunk(
return false;
}
- private boolean recordAlignedChunk(final List<Chunk> valueChunkList, final
byte marker)
- throws IOException {
- if (!valueChunkList.isEmpty()) {
- final Chunk timeChunk = timeChunkList.get(lastIndex);
+ private boolean recordPendingAlignedChunk(final byte marker) throws
IOException {
Review Comment:
Agreed. This method consumes the next pending aligned chunk instead of
recording one, so I renamed it to useNextPendingAlignedChunk in 028deefe245.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
