jt2594838 commented on code in PR #18031:
URL: https://github.com/apache/iotdb/pull/18031#discussion_r3473838830
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/load/LoadTsFileAnalyzer.java:
##########
@@ -83,6 +83,11 @@ public class LoadTsFileAnalyzer implements AutoCloseable {
private static final Logger LOGGER =
LoggerFactory.getLogger(LoadTsFileAnalyzer.class);
+ private static final String MISSING_SCHEMA_MESSAGE =
+ "does not exist in IoTDB and can not be created";
+ private static final String AUTO_CREATE_SCHEMA_HINT_MESSAGE =
+ "Please check weather auto-create-schema is enabled";
Review Comment:
i18n
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/visitor/PipeStatementTSStatusVisitor.java:
##########
@@ -74,6 +74,7 @@ public TSStatus visitNode(final StatementNode node, final
TSStatus status) {
public TSStatus visitLoadFile(
final LoadTsFileStatement loadTsFileStatement, final TSStatus status) {
if (status.getCode() == TSStatusCode.SYSTEM_READ_ONLY.getStatusCode()
+ || status.getCode() ==
TSStatusCode.LOAD_TEMPORARY_UNAVAILABLE_EXCEPTION.getStatusCode()
|| status.getCode() == TSStatusCode.LOAD_FILE_ERROR.getStatusCode()
&& status.getMessage() != null
&& status.getMessage().contains("memory")) {
Review Comment:
Will the message one day be involved in i18n?
If so, the `contains()` call may become dangerous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
