PDGGK commented on PR #17411:
URL: https://github.com/apache/iotdb/pull/17411#issuecomment-4802405379

   Rebased onto the latest master. The only conflict was in 
`LastQueryAggTableScanOperator`, where the table last-row optimization was 
refactored since this PR was opened (the accumulator classes moved to the 
`calc-commons` module and the `EMPTY_PRIMITIVE_TYPE` placeholder was renamed to 
`PLACEHOLDER_NO_VALUE`); I reconciled the fix against those changes, and the 
`last_by` empty-result handling (`shouldSkipEmptyLastByResult`) is preserved. 
The two regression tests in `IoTDBDeletionTableIT` are unchanged.
   
   @Caideyipi would you have a chance to take a look? You touched this operator 
most recently (#17677), so your eyes here would be very helpful. Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to