github-advanced-security[bot] commented on code in PR #18026: URL: https://github.com/apache/iotdb/pull/18026#discussion_r3479890208
########## iotdb-client/cli/src/main/java/org/apache/iotdb/tool/common/Constants.java: ########## @@ -68,6 +68,14 @@ public static final String TRUST_STORE_PWD_NAME = "trust_store_password"; public static final String TRUST_STORE_PWD_DESC = "Trust store password. (optional)"; + public static final String KEY_STORE_ARGS = "ks"; + public static final String KEY_STORE_NAME = "key_store"; + public static final String KEY_STORE_DESC = "Key store for mutual SSL. (optional)"; + + public static final String KEY_STORE_PWD_ARGS = "kpw"; Review Comment: ## SonarCloud / Credentials should not be hard-coded <!--SONAR_ISSUE_KEY:AZ78sBwQIpeCryPNl2Yh-->'PWD' detected in this expression, review this potentially hard-coded password. <p>See more on <a href="https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ78sBwQIpeCryPNl2Yh&open=AZ78sBwQIpeCryPNl2Yh&pullRequest=18026";>SonarQube Cloud</a></p> [Show more details](https://github.com/apache/iotdb/security/code-scanning/417) ########## iotdb-client/cli/src/main/java/org/apache/iotdb/cli/AbstractCli.java: ########## @@ -74,17 +74,21 @@ static final String USE_SSL_ARGS = "usessl"; static final String TRUST_STORE_ARGS = "ts"; + static final String KEY_STORE_ARGS = "ks"; static final String TRUST_STORE_PWD_ARGS = "tpw"; + static final String KEY_STORE_PWD_ARGS = "kpw"; Review Comment: ## SonarCloud / Credentials should not be hard-coded <!--SONAR_ISSUE_KEY:AZ78sBxMIpeCryPNl2Yi-->'PWD' detected in this expression, review this potentially hard-coded password. <p>See more on <a href="https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ78sBxMIpeCryPNl2Yi&open=AZ78sBxMIpeCryPNl2Yi&pullRequest=18026";>SonarQube Cloud</a></p> [Show more details](https://github.com/apache/iotdb/security/code-scanning/418) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
