PDGGK commented on PR #17180: URL: https://github.com/apache/iotdb/pull/17180#issuecomment-4830219540
Thanks for the interest, @henjoe — this isn't merged yet, it's still awaiting review. @JackieTien97 the branch is up to date and mergeable whenever you have a chance to look. Quick recap of the change: it adds the inclusive interval syntax `[start, end]` to `GROUP BY` time alongside the existing half-open `[start, end)` form, so the right boundary can be included (e.g. `GROUP BY ([0, 100], 10ms)` produces a final window that includes timestamp 100). Implemented via a `rightClosed` flag threaded through the grammar, `GroupByTimeComponent`/`GroupByTimeParameter`, and the time-range iterators, with `ExpressionFactory` normalizing `[start, end]` to `[start, end+1)` (guarding against `Long.MAX_VALUE` overflow). Tests are in `TimeRangeIteratorTest`. Happy to rebase or address any feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
