DaZuiZui commented on PR #18006: URL: https://github.com/apache/iotdb/pull/18006#issuecomment-4901245378
Follow-up update for custom FFT time columns: - Added optional `TIMECOL` support for `FFT`, defaulting to `time`, so tables with custom TIME column names such as `event_time TIMESTAMP TIME` can use FFT directly. - Validation now requires `DATA ... ORDER BY` to reference the column selected by `TIMECOL`, and FFT excludes that selected time column from value columns. - Moved `TIMECOL` to the end of the FFT argument specification (`DATA, SAMPLE_INTERVAL, N, NORM, TIMECOL`) to preserve existing positional-argument semantics. Named usage such as `TIMECOL => 'event_time'` is supported as expected. - Added unit/planner/IT coverage for custom time column usage, plus planner coverage that positional arguments like `FFT(TABLE(table1) ORDER BY time, 1s, 4, 'ortho')` still bind `1s` to `SAMPLE_INTERVAL`. This was merged into the PR branch with a normal push, no force push. Verification run locally: - `./mvnw spotless:apply -pl iotdb-core/node-commons,iotdb-core/datanode` - `./mvnw test -pl iotdb-core/node-commons -am -Dtest=FFTTableFunctionTest -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false -DskipITs` - `./mvnw test -pl iotdb-core/datanode -am -Dtest=TableFunctionTest#testFFTWithSpecifiedTimeColumn+testFFTPositionalArgumentsKeepExistingOrder -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false -DskipITs` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
