Caideyipi commented on PR #18132: URL: https://github.com/apache/iotdb/pull/18132#issuecomment-4921438719
Thanks for addressing the previous review comments. I re-checked the latest revision and there is still one blocking issue. High: the new table-model `insertTablets` path can still drop data in cluster mode. The current batch path catches `RedirectException` and only updates the leader cache via `handleRelationalTabletsRedirection`, but it does not retry the redirected tablets/rows. In addition, `SessionConnection.insertTablets()` throws the multi-device redirection as `deviceEndPointMap`, while the new `handleRelationalTabletsRedirection` only reads `getEndPointList()`, so in this case the table-model leader cache may not even be refreshed. This is also visible in the current CI failure, and it hits the new/related tests directly: - `IoTDBSessionRelationalIT.insertTabletsAutoCreateTableTest`: expected 40 rows but got 20. - `IoTDBInsertTableSessionPoolIT.testInsertTabletsWithDifferentTables`: expected 5 rows but got 0. Could you please make the batch `insertTablets` redirection handling complete? After receiving per-device/per-row redirect information, the client should regroup the affected tablets/rows by endpoint and retry the unwritten data, instead of only updating the cache and returning successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
