Copilot commented on code in PR #18204:
URL: https://github.com/apache/iotdb/pull/18204#discussion_r3579114981
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/ExternalTsFileTableScanOperator.java:
##########
@@ -97,6 +97,13 @@ public void initQueryDataSource(IQueryDataSource dataSource)
{
super.initQueryDataSource(currentDataSource);
}
+ @Override
+ protected boolean shouldStopScanByRuntimeFilter() {
+ // Each device uses its own QueryDataSource, exhausting files for the
current device must not
+ // stop scanning remaining devices in the same external TsFile task.
+ return false;
+ }
Review Comment:
`shouldStopScanByRuntimeFilter()` currently always returns false, but the
unit test added in this PR expects the external TsFile scan to stop early by
runtime filter once it reaches the *last* device and the current device's
QueryDataSource has no valid resources. Always returning false can keep the
operator iterating on the last device even when file-level RF has exhausted its
resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
