JackieTien97 commented on code in PR #18228:
URL: https://github.com/apache/iotdb/pull/18228#discussion_r3594562829
##########
iotdb-protocol/thrift-confignode/src/main/thrift/confignode.thrift:
##########
@@ -129,6 +129,7 @@ struct TRuntimeConfiguration {
10: optional bool enableSeparationOfAdminPowers
// use 'optional' here to support rolling upgrade
11: optional list<common.TExternalServiceEntry> allUserDefinedServiceInfo
+ 12: required i64 fenceThresholdMs
Review Comment:
```suggestion
12: optional i64 fenceThresholdMs
```
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/table/DataNodeTableCache.java:
##########
@@ -158,6 +158,13 @@ public void reloadTableCacheAfterLeaseRecovery() {
if (resp.isSetTableInfo()) {
init(resp.getTableInfo());
}
+ if (!resp.isSetFenceThresholdMs()) {
+ throw new
RuntimeException(DataNodeSchemaMessages.FAILED_TO_GET_FENCE_THRESHOLD_FROM_CN);
+ }
Review Comment:
I don't understand why we need to reupdate fence threshold here? as
discussed before, I think we need to update through heartbeat?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/table/DataNodeTableCache.java:
##########
@@ -158,6 +158,13 @@ public void reloadTableCacheAfterLeaseRecovery() {
if (resp.isSetTableInfo()) {
init(resp.getTableInfo());
}
+ if (!resp.isSetFenceThresholdMs()) {
Review Comment:
if you think this must be included, you can set that as required instead of
optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
