Caideyipi commented on code in PR #18262:
URL: https://github.com/apache/iotdb/pull/18262#discussion_r3627886213
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/PipeTsFileInsertionEvent.java:
##########
@@ -900,22 +918,35 @@ private void waitForResourceEnough4Parsing(final long
timeoutMs) throws Interrup
waitTimeSeconds);
}
- if (waitTimeSeconds * 1000 > timeoutMs) {
- // should contain 'TimeoutException' in exception message
- throw new PipeRuntimeOutOfMemoryCriticalException(
- String.format(
- DataNodePipeMessages
-
.PIPE_EXCEPTION_TIMEOUTEXCEPTION_WAITED_S_SECONDS_FOR_MEMORY_TO_PARSE_TSFILE_0E4EF8FD,
- waitTimeSeconds));
+ if (tryReserveTsFileParserMemory(memoryManager)) {
+ LOGGER.info(
+ DataNodePipeMessages.WAIT_FOR_MEMORY_ENOUGH_FOR_PARSING_FOR,
+ resource != null ? resource.getTsFilePath() : "tsfile",
+ waitTimeSeconds);
+ return;
}
+
+ memoryCheckIntervalMs =
+ getNextMemoryCheckIntervalMs(memoryCheckIntervalMs,
maxMemoryCheckIntervalMs);
}
+ }
+
+ static long getMaxMemoryCheckIntervalMs(final long initialIntervalMs, final
int maxRetries) {
+ final long multiplier = Math.max(1, maxRetries);
+ return initialIntervalMs > Long.MAX_VALUE / multiplier
+ ? Long.MAX_VALUE
+ : initialIntervalMs * multiplier;
+ }
Review Comment:
Thanks, addressed in 606c24f3270. I added a description next to
pipeMemoryAllocateMaxRetries clarifying that, besides limiting allocation
retries, it also caps the TsFile parser memory admission backoff at
pipeCheckMemoryEnoughIntervalMs * max(1, pipeMemoryAllocateMaxRetries).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
