Caideyipi commented on code in PR #18254:
URL: https://github.com/apache/iotdb/pull/18254#discussion_r3635204999


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java:
##########
@@ -193,6 +190,15 @@ public TsFileInsertionEventScanParser(
         isWithMod);
   }
 
+  private static TsFileSequenceReader createTsFileSequenceReader(
+      final File tsFile, final boolean hasModifications) throws IOException {
+    if (hasModifications) {
+      return new TsFileSequenceReader(tsFile.getAbsolutePath(), true, true);
+    }
+
+    return new TsFileSequenceReader(new BufferedTsFileInput(tsFile.toPath()), 
false, false, null);

Review Comment:
   Addressed in 63cb9890636. The scan parser now explicitly uses an 8 KiB 
buffer, allocates a same-sized Pipe parser memory block before creating 
BufferedTsFileInput, and closes that block with the parser lifecycle.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to