CRZbulabula opened a new pull request, #18292:
URL: https://github.com/apache/iotdb/pull/18292

   ## Description
   
   The DataNode Logback configuration still declares an `AUDIT` rolling file 
appender that targets `log_datanode_audit.log`, together with the 
`IoTDB_AUDIT_LOGGER` logger. The audit implementation has already been removed, 
so there are no remaining Java callers. However, Logback initializes the 
rolling file appender when the DataNode starts, which creates an unused audit 
log file.
   
   This PR:
   
   - removes the obsolete audit appender and logger from the production 
DataNode Logback configuration;
   - removes the equivalent configuration from the three DataNode test 
configurations;
   - removes the unused `AUDIT_LOGGER_NAME` constant.
   
   This change only removes the obsolete standalone audit log file output. It 
does not change the existing audit privilege or authorization behavior.
   
   ## Verification
   
   - `mvn spotless:apply -pl iotdb-core/node-commons`
   - `mvn compile -pl iotdb-core/node-commons -DskipTests`
   - validated all modified Logback XML files with `xmllint`
   - confirmed that no audit appender, logger name, or audit log file reference 
remains in the affected modules
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   
   <hr>
   
   ##### Key changed files
   
   - `iotdb-core/datanode/src/assembly/resources/conf/logback-datanode.xml`
   - `iotdb-core/datanode/src/test/resources/datanode{1,2,3}conf/logback.xml`
   - 
`iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/conf/IoTDBConstant.java`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to