jt2594838 commented on code in PR #18271:
URL: https://github.com/apache/iotdb/pull/18271#discussion_r3637470801
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/LoadTsFileStatement.java:
##########
@@ -195,6 +201,31 @@ private static void validateLoadSourcePath(final File
file) throws FileNotFoundE
Arrays.toString(allowedDirs)));
}
+ private static Path[] getInternalTsFileDirCanonicalPaths() throws
FileNotFoundException {
+ final String[] localDataDirs =
IoTDBDescriptor.getInstance().getConfig().getLocalDataDirs();
+ final Path[] internalTsFileDirCanonicalPaths = new
Path[localDataDirs.length * 2];
+ for (int i = 0; i < localDataDirs.length; i++) {
+ internalTsFileDirCanonicalPaths[i * 2] =
+ canonicalPath(new File(localDataDirs[i], SEQUENCE_FOLDER_NAME));
+ internalTsFileDirCanonicalPaths[i * 2 + 1] =
+ canonicalPath(new File(localDataDirs[i], UNSEQUENCE_FOLDER_NAME));
+ }
+ return internalTsFileDirCanonicalPaths;
+ }
Review Comment:
Pipe hardlink dir, region snapshot dir, etc., should also be excluded.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/LoadTsFileStatement.java:
##########
@@ -195,6 +201,31 @@ private static void validateLoadSourcePath(final File
file) throws FileNotFoundE
Arrays.toString(allowedDirs)));
}
+ private static Path[] getInternalTsFileDirCanonicalPaths() throws
FileNotFoundException {
+ final String[] localDataDirs =
IoTDBDescriptor.getInstance().getConfig().getLocalDataDirs();
+ final Path[] internalTsFileDirCanonicalPaths = new
Path[localDataDirs.length * 2];
+ for (int i = 0; i < localDataDirs.length; i++) {
+ internalTsFileDirCanonicalPaths[i * 2] =
+ canonicalPath(new File(localDataDirs[i], SEQUENCE_FOLDER_NAME));
+ internalTsFileDirCanonicalPaths[i * 2 + 1] =
+ canonicalPath(new File(localDataDirs[i], UNSEQUENCE_FOLDER_NAME));
+ }
+ return internalTsFileDirCanonicalPaths;
+ }
Review Comment:
This does not need to be initialized for each load.
You may cache it in IoTDBConfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
