Copilot commented on code in PR #18299:
URL: https://github.com/apache/iotdb/pull/18299#discussion_r3643495082
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/client/request/AsyncRequestManager.java:
##########
@@ -210,6 +210,7 @@ protected void sendAsyncRequest(
endPoint,
e.getMessage(),
retryCount);
+ onRequestFailure(e, endPoint);
Review Comment:
`onRequestFailure(e, endPoint)` is a reporting hook, but if an override
throws a RuntimeException it will replace the original transport failure
handling (and can prevent `handler.onError(e)`/latch countdown). Wrap the hook
in a try/catch and suppress the hook failure onto the original exception
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
