Caideyipi opened a new pull request, #18385:
URL: https://github.com/apache/iotdb/pull/18385

   ## Description
   
   Backport #18362 (`154644107a82ba69431725390b8346149263bd0e`) to `dev/1.3`.
   
   A global `source.start-time` or `source.end-time` previously enabled 
historical extraction unconditionally. As a result, 
`source.history.enable=false` could still transfer data that existed before 
pipe creation.
   
   This backport:
   - computes historical enablement independently from the global time range;
   - preserves the default behavior when `source.history.enable` is omitted;
   - preserves historical recovery for pipe restarts and newly added 
DataRegions;
   - keeps global time-range precedence over history-specific ranges and 
updates the validation warning;
   - adapts the historical implementation and regression test to the 1.3 
`PipeHistoricalDataRegionTsFileSource` API.
   
   ## Verification
   
   - `mvn spotless:apply -pl iotdb-core/datanode`
   - `mvn spotless:apply -pl integration-test -P with-integration-tests`
   - 
`PipeHistoricalDataRegionTsFileSourceTest#testGlobalTimeRangeRespectsHistoryEnable`:
 1 test, 0 failures
   - `git diff --check`
   
   The full DataNode Maven test was also attempted, but this checkout has 
unrelated pre-existing compilation errors in Pipe builder/sink classes; the 
changed sources were isolated-compiled and the targeted test passed.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added or modified unit tests.
   - [x] added an integration-test regression case.
   
   <hr>
   
   ##### Key changed/added classes
   
   - `PipeHistoricalDataRegionTsFileSource`
   - `IoTDBDataRegionSource`
   - `PipeHistoricalDataRegionTsFileSourceTest`
   - `IoTDBPipeSourceIT`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to