PDGGK commented on PR #118: URL: https://github.com/apache/iotdb-extras/pull/118#issuecomment-5162397352
Thanks — item 1 is a real break and I had missed it in exactly the way you describe. Pushed as `c244362`. **The pom.** `install-node-and-yarn` / Node 16.13.1 / Yarn 1.22.17 → `install-node-and-npm` / Node 22.11.0, and `yarn install` / `yarn build` → `npm ci` / `npm run build`. `ci` rather than `install` so the lockfile stays authoritative and a drifted dependency set fails the build instead of resolving silently. I left a comment on the node version pointing at `.nvmrc` so the two do not drift apart again, and called out in the description that `.npmrc`'s `ignore-scripts=true` applies to the Maven-driven install as well — you were right that it was an undocumented behaviour change. Verified locally: `mvn clean package -Pwith-grafana-plugin -DskipTests -ntp` is green end to end, 45s, with `antrun:3.1.0:run (test)` executing and six backend binaries plus `module.js` carrying build-time timestamps. One caveat on that run: I needed `GOFLAGS=-buildvcs=false`, which is a workaround for a broken `.git` directory in my own home path, not something CI needs — I deliberately did not put it in the job. **Item 2.** Added as a second job in `grafana-plugin.yml` rather than a step in `compile-check.yml`, so it stays with the module it covers. I checked your diagnosis and it holds: `with-all-connectors` lists nine modules and `grafana-plugin` is not among them, and the Jenkinsfile's plain `mvn clean install` does not activate `with-grafana-plugin` either. One thing worth recording from getting that job green: the antrun execution has `<id>test</id>` but is bound to `<phase>package</phase>`, so `-DskipTests` does **not** skip it — the Maven job really does run `backend-compile.sh`. That is fine, and it is why the job needs `setup-go`, but the id is misleading and I would not have caught it by reading the id alone. **Item 3.** Agreed that both belong to the PMC rather than to this PR, and I will raise them on `dev@` as one thread with two sections — the `grafanaDependency` floor as a compatibility decision, and the `.config/AGENTS/` directory together with the LICENSE/NOTICE question you raised. I will link the thread here. One observation I am deliberately *not* folding in, since it is pre-existing and this PR does not touch the file: `backend-compile.sh` runs `go get -u github.com/grafana/[email protected]` and `go mod tidy` at build time, so a build can mutate `go.mod`. Mine bumped `magefile/mage` from v1.15.0 to v1.17.2, which I reverted before committing. Happy to open that as its own issue once this lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
