jt2594838 commented on code in PR #18402:
URL: https://github.com/apache/iotdb/pull/18402#discussion_r3725340564
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ProgressWALIterator.java:
##########
@@ -114,23 +116,29 @@ private void refreshFileList() {
final File[] discoveredWalFiles =
WALFileUtils.listAllWALFiles(logDirectory);
if (discoveredWalFiles == null) {
walFiles = new File[0];
+ walFileVersionIds = new long[0];
return;
}
WALFileUtils.ascSortByVersionId(discoveredWalFiles);
- final List<File> filteredWalFiles = new
ArrayList<>(discoveredWalFiles.length);
+ final File[] filteredWalFiles = new File[discoveredWalFiles.length];
+ final long[] filteredWalFileVersionIds = new
long[discoveredWalFiles.length];
+ int filteredWalFileCount = 0;
for (int i = 0; i < discoveredWalFiles.length; i++) {
final File walFile = discoveredWalFiles[i];
+ final long versionId = WALFileUtils.parseVersionId(walFile.getName());
final boolean isLastWalFile = i == discoveredWalFiles.length - 1;
- if (!isLastWalFile && shouldSkipWalFile(walFile)) {
+ if (!isLastWalFile && shouldSkipWalFile(walFile, versionId)) {
continue;
}
- filteredWalFiles.add(walFile);
+ filteredWalFiles[filteredWalFileCount] = walFile;
+ filteredWalFileVersionIds[filteredWalFileCount] = versionId;
+ filteredWalFileCount++;
}
- walFiles = filteredWalFiles.toArray(new File[0]);
+ walFiles = Arrays.copyOf(filteredWalFiles, filteredWalFileCount);
+ walFileVersionIds = Arrays.copyOf(filteredWalFileVersionIds,
filteredWalFileCount);
Review Comment:
May record `filteredWalFileCount` instead of copying the array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
