Lexert19 commented on PR #17439: URL: https://github.com/apache/iotdb/pull/17439#issuecomment-5208703274
Hi @PDGGK, thank you for the detailed review! I have addressed all your points: I updated the tests to assert on exact epoch milliseconds, unified the formatters using `ISO_LOCAL_DATE_WIDTH_1_2 `so parsing behavior is consistent, added tests to codify the new edge-case syntax, cleaned up the unused depth logic and `DATETIME_CONVERT_FAILED `message, completely deleted the problematic `toZoneOffset `method, and added .parseCaseInsensitive() to the new formatters. Hi @Wei-hao-Li, since you were requested as a reviewer on this PR, could you please approve running the CI workflow and give this PR a review when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
