jt2594838 commented on code in PR #18460:
URL: https://github.com/apache/iotdb/pull/18460#discussion_r3772306598
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/WritingMetrics.java:
##########
@@ -845,7 +840,17 @@ public void recordFlushingMemTableStatus(
POINTS_NUM,
Tag.REGION.toString(),
dataRegionId.toString());
- avgPointHistogram.update(avgSeriesNum);
+ MetricService.getInstance()
+ .histogram(
+ avgSeriesNum,
+ Metric.FLUSHING_MEM_TABLE_STATUS.toString(),
+ MetricLevel.IMPORTANT,
+ Tag.NAME.toString(),
+ AVG_SERIES_POINT_NUM,
Review Comment:
This keeps avg_series_points_num in the same per-DataRegion metric lifecycle
as the other flushing histograms. Recording with the current Region tag
prevents samples from all Regions being routed to whichever histogram was
registered last, which was the source of the zero P50/P99 series.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
