PDGGK opened a new pull request, #124: URL: https://github.com/apache/iotdb-extras/pull/124
The calendar-aggregation Javadoc I added in #115 says `date_bin` > exposes *no timezone argument* (it computes in the server's UTC zone only). The first half is right; **the parenthetical is wrong**, and it was wrong when I wrote it rather than having gone stale. `DateBinFunctionColumnTransformer.dateBin(long source, long origin, int monthDuration, long nonMonthDuration, ZoneId zoneId)` converts through `LocalDateTime` in that `ZoneId`, and `ColumnTransformerBuilder`'s `DATE_BIN` branch passes `context.sessionInfo.getZoneId()` — identically at `v2.0.8` (the version the Javadoc names) and on `master`. It has never been UTC-only. `TableSessionPoolBuilder.zoneId(...)` even defaults to `ZoneId.systemDefault()`, so UTC is not the default either. The design decision the paragraph justifies does not change: this path still has to walk calendar boundaries in Java. But the accurate reason is different, and it is a stronger one — the zone is **session-scoped**, fixed when the session pool is built, so a pooled session cannot rebind it per query, whereas each `ReadTsKvQuery` carries its own `tzId`. The day-of-month anchoring half of the original sentence stands unchanged. Comment-only change; no behaviour is affected. Verified `mvn -P with-thingsboard compile` and applied `spotless:apply` (which reflowed the surrounding paragraph, hence the slightly larger diff). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
